vsantonastaso commented on PR #10799:
URL: https://github.com/apache/seatunnel/pull/10799#issuecomment-4516230634
Hi @DanielLeens @davidzollo , thanks again for the detailed pass, really
appreciate the thoroughness.
On Issue 1, I had a look and those workflow and Milvus changes are not
coming from this branch. Both d185eb4e1 (the CI engine module shortcut, #10783)
and
d991e6bbb (the Milvus split-balancing fix, #10868) were already merged
into apache:dev before this branch was based. The "Files changed" tab on the PR
shows exactly 10 files, and a git diff apache/dev...2cfab333b confirms the
same. So it is a false positive.
On Issue 2, the unit tests are actually all green across Java 8 and 11 on
Ubuntu and Windows. What's failing is the updated-modules integration test
matrix, because we touched the CDC base POM (scope change), the CI's
module detection flags everything that transitively depends on it, which pulls
in Paimon and Doris e2e. Those failures have nothing to do with our changes,
the CDC runtime path is byte-for-byte identical to dev, we only changed the
Maven scope declaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
