DanielLeens commented on PR #10879:
URL: https://github.com/apache/seatunnel/pull/10879#issuecomment-4518061906
Thanks for the follow-up. I pulled the latest head
`9c97b26bb3a271b5edd30a56c2d5900ddb965e9a` locally as `seatunnel-review-10879`
and re-reviewed the current PR state against `apache/dev`.
The important point on this round is that the delta after Daniel's last
reviewed head `b4442561c185b489b97e7d69ef237a610b0c28af` is docs-only:
```text
git diff --name-status b4442561c185b489b97e7d69ef237a610b0c28af...HEAD
M docs/en/connectors/source/EdgeSocket.md
M docs/zh/connectors/source/EdgeSocket.md
```
# What this PR fixes
- User pain: beyond the EdgeSocket source itself, users need a standalone
edge agent that can batch, persist, resend, and reliably feed edge-side data
into SeaTunnel.
- Fix approach: edge agent dist/runtime/WAL/transport/E2E integration, plus
the protocol/docs surface.
- In one sentence: this is the SeaTunnel Edge Agent MVP and dist integration.
# Runtime path I rechecked
```text
edge agent
-> input reader / position store / WAL
-> batchId allocation
-> transport client (__AUTH__ / __BATCH__ / __COMMIT__)
-> EdgeSocketIngressServer
-> queue / backpressure / ACK watermark
-> downstream Zeta pipeline
```
Since the latest delta is documentation only, the main question was whether
the refreshed EdgeSocket docs still match the runtime assumptions that the edge
agent depends on. I rechecked the key points that matter here:
- `parallelism = 1`
- single collector model
- TOKEN auth
- `QUEUE_FULL`, `RESEND`, `REJECTED`, and watermark ACK semantics
Those constraints are still described consistently with the implementation,
and I do not see a new source-level blocker on the current head.
# Testing coverage and stability
There is no new test-code delta on top of the previously reviewed head, so I
do not see a new stability concern introduced by this docs-only refresh.
# Merge conclusion
### Conclusion: can merge
1. Blocking items
- I did not find a blocking issue on the current head.
2. Suggested follow-up items
- None.
Overall, the latest update is a documentation refresh on top of the
already-reviewed Edge Agent implementation, and the refreshed docs still match
the protocol/runtime contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
