DanielLeens commented on issue #10933:
URL: https://github.com/apache/seatunnel/issues/10933#issuecomment-4527061755

   Thanks for the clear report, and also for opening PR #10934 so quickly.
   
   I checked the current JDBC Dameng auto-create path, and this does look like 
a real bug rather than a configuration issue.
   
   In the current implementation, `DamengCreateTableSqlBuilder` appends the 
`COMMENT ON COLUMN ...` statements to the same SQL text as `CREATE TABLE`, and 
`AbstractJdbcCatalog.createTableInternal()` then sends that returned SQL 
through a single `PreparedStatement.execute()` call. That matches the Dameng 
parser error you posted when column comments are present.
   
   So this issue should stay open until the fix is merged. Since you already 
opened #10934, the best next step is to continue the implementation discussion 
there instead of splitting it across two threads.
   
   From the maintainer side, the important review point will be to keep Dameng 
column-comment support, while splitting the create-table and comment execution 
path cleanly for the auto-create flow.
   
   Thanks again for the precise reproduction and for preparing the fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to