DanielLeens commented on PR #10890:
URL: https://github.com/apache/seatunnel/pull/10890#issuecomment-4538714748
Thanks for the update. I re-reviewed the latest head from scratch. The
current diff is now focused on the SQL Server CDC schema-evolution path itself,
and I do not see a reopened source-level blocker on this revision.
# What this PR fixes
- User pain: SQL Server CDC needs to propagate add / drop / rename / modify
schema changes correctly to downstream consumers.
- Fix approach: the current head dispatches pending DDL history from the
streaming change source, explicitly detects sp_rename COLUMN statements, and
adds E2E coverage for add/drop/rename/modify.
- One-line summary: the main SQL Server schema-evolution path now looks
coherent to me; the remaining gate is that the latest Build was cancelled and
needs a fresh CI result.
# Runtime chain I checked
~~~text
Streaming CDC path
-> SqlServerStreamingChangeEventSource.java:387-409,469-474
-> migrateTable() and dispatchPendingDdlHistory(...) around schema-change
checkpoints
-> dispatcher.dispatchDataChangeEvent(...) for row changes
Schema-change resolution
-> SqlServerSchemaChangeResolver.java:110-124,170-252
-> parseSpRenameColumns(ddl)
-> diffColumns() produces add/drop/modify/change events
Coverage
-> SqlServerCDCIT.java:791-834 covers add/drop/rename/modify
~~~
# Findings
- No new blocking source-level issue found on the current head.
# CI note
- The current Build check is CANCELLED, not a functional failure, but it
still means the latest head does not yet have a final green CI signal.
# Merge conclusion
### Conclusion: can merge after fixes
1. Blocking items
- Please rerun the full Build on the current head so the final CI result is
available.
2. Suggested non-blocking follow-up
- None from the source-review side. The runtime path itself looks close to
done.
Overall, this revision looks much closer to a finished SQL Server
schema-evolution implementation. The remaining gate is CI completeness rather
than a new code-path blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
