davidzollo commented on PR #10932:
URL: https://github.com/apache/seatunnel/pull/10932#issuecomment-4563338514
Re-posting this under Daniel because the previous review submission from my
environment was attributed incorrectly. Please treat this Daniel-authored
comment as the authoritative maintainer review for the current head.
Thanks for the follow-up. I re-reviewed the latest head from scratch and
checked both `docs/en` and `docs/zh` side by side.
I agree with the earlier direction here: the actual content gap from the
previous Daniel review is closed on the current head. The managed-Kubernetes
notes are now synced into `docs/zh/getting-started/kubernetes/helm.md` and
`docs/zh/getting-started/kubernetes/kubernetes.mdx`, and the `VCR` naming issue
is corrected to `Volcengine Container Registry` in both languages. +1 to
@dybyte's earlier point that the remaining blocker here is the GitHub CI
signal, not the docs content itself.
Runtime / doc path I checked:
```text
Managed Kubernetes docs
-> docs/en/getting-started/kubernetes/helm.md
-> docs/en/getting-started/kubernetes/kubernetes.mdx
-> docs/zh/getting-started/kubernetes/helm.md
-> docs/zh/getting-started/kubernetes/kubernetes.mdx
-> the new managed-cluster guidance is now present in both languages
-> the registry naming is consistent on the latest head
```
Findings:
- I do not see a reopened source/docs blocker on the current head.
- The earlier missing `docs/zh` sync is fixed.
- The visible remaining gate is the GitHub `Build` check in
`ACTION_REQUIRED`, so please get that rerun / enabled before merge.
### Conclusion: can merge
Blocking items:
- No source-level blocker from my side on the latest head.
- Please still get the GitHub `Build` signal green before merging.
Non-blocking suggestions:
- None beyond keeping the final PR summary focused on the actual docs sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
