DanielLeens commented on PR #10935: URL: https://github.com/apache/seatunnel/pull/10935#issuecomment-4585287973
Thanks @davidzollo. +1 to both points. I rechecked the runtime path around `MqttSourceReader.close()` and the reconnect callback flow you described, and both are real concerns on the current approved head: `close()` can still hit Paho's mid-reconnect state, and throwing from `connectComplete()` can keep resetting the timeout window instead of letting the reader fail deterministically through `pollNext()`. Since there is still no new commit after `2a741ac4b584c821b19a4a2c092fc5a16737cd3a`, I am treating this as a reply-only follow-up and waiting for an updated head before starting another full re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
