goutamadwant opened a new pull request, #10987:
URL: https://github.com/apache/seatunnel/pull/10987
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
Fixes #10899.
For `startup.mode = timestamp`, the initial incremental split stores a
timestamp-only binlog offset. That offset should be resolved to a concrete
MySQL binlog position before the reader starts.
After a checkpoint restore, the split already contains the concrete binlog
offset saved by the reader. Reusing the configured timestamp at that point can
move the recovery anchor back to the original startup timestamp, so this change
uses the restored offset directly and skips the timestamp event filter for
restored binlog offsets.
### Does this PR introduce _any_ user-facing change?
Yes. MySQL CDC jobs configured with `startup.mode = timestamp` can recover
from checkpoints using the saved binlog offset, instead of resolving the
original startup timestamp again.
### How was this patch tested?
Added unit coverage for both restore decisions:
- `MySqlSourceFetchTaskContext` only resolves the configured timestamp for
timestamp-only bootstrap offsets.
- `MySqlBinlogFetchTask` only applies the timestamp filter for
timestamp-only bootstrap offsets.
Verified with:
```shell
JAVA_HOME=$(/usr/libexec/java_home -v 11) PATH="$JAVA_HOME/bin:$PATH" ./mvnw
-pl seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql
-DfailIfNoTests=false package
```
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
