QuakeWang opened a new pull request, #10991:
URL: https://github.com/apache/seatunnel/pull/10991
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull
request adds checkstyle plugin.-->
Fix Paimon sink branch handling in save mode and schema evolution.
Previously, Paimon save mode DDL was executed against the main table before
the writer switched to the configured branch. This could make
`schema_save_mode=RECREATE_SCHEMA` drop/recreate the main table,
`data_save_mode=DROP_DATA` truncate the main table, or branch auto-create
scenarios accidentally create a main table.
Schema evolution also used a non-branch Paimon `Identifier`, so alter table
events were applied to the main table while the writer wrote to the branch.
This PR rejects unsupported non-main branch save mode paths before DDL
execution and applies schema evolution with a branch-aware `Identifier`.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new
specifications: https://github.com/apache/seatunnel/issues/4544.
-->
Yes.
For Paimon sink non-main branches, the main table and target branch must
already exist. `schema_save_mode=RECREATE_SCHEMA` and
`data_save_mode=DROP_DATA` are rejected for non-main branches to avoid
modifying the main table.
The Paimon sink documentation is updated with this constraint.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If you are adding E2E test cases, maybe refer to
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
here is a good example.
-->
Added `PaimonBranchSaveModeHandlerTest` to cover:
- missing main table does not auto-create a main table for branch writes
- missing branch fails without auto-creating the branch
- `data_save_mode=DROP_DATA` does not truncate/drop branch metadata
- `schema_save_mode=RECREATE_SCHEMA` does not drop/recreate the main table
- restore save mode path rejects destructive branch save mode
- schema evolution alters only the target branch schema
Verified with:
```bash
./mvnw spotless:check -pl seatunnel-connectors-v2/connector-paimon
./mvnw -pl seatunnel-connectors-v2/connector-paimon
-Dtest=PaimonBranchSaveModeHandlerTest test
./mvnw spotless:apply -pl seatunnel-connectors-v2/connector-paimon
./mvnw -q -DskipTests verify
```
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [x] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
