nzw921rx opened a new pull request, #11001:
URL: https://github.com/apache/seatunnel/pull/11001

   ### Purpose of this pull request
   
   Fix UT flaky tests and resource contention issues in 
`seatunnel-transforms-v2`.
   
   **Bug fix:**
   - Fix `FilterFieldTransformTest.testConfig` using try/catch instead of 
`assertThrows` — if no exception is thrown, the test silently passes (false 
green)
   
   **Port conflict:**
   - Fix `LLMRequestJsonTest.testCustomOllamaRequestJson` using hardcoded port 
`mockWebServer.start(11434)` — replaced with ephemeral port 
`mockWebServer.start()` + dynamic URL resolution to avoid CI port conflicts
   
   **Resource cleanup:**
   - Fix `LLMRequestJsonTest.testCustomRequestJson` missing `model.close()`, 
leaking HTTP client
   - Fix `EmbeddingRequestJsonTest.testCustomParseResponse` missing 
`customModel.close()`, leaking HTTP client
   - Fix `EmbeddingModelDimensionTest` — all 3 test methods missing 
`model.close()` after assertions
   
   **Timezone stability:**
   - Fix `DateTimeFunctionTest.testAtTimeZoneFunction` and 
`testFromUnixtimeFunction` using `ZoneId.systemDefault()` / `assertNotNull` — 
pin to UTC with explicit expected values so tests pass regardless of CI timezone
   - Fix `SQLDateTimeFunctionsTest.testAtTimeZone` same 
`ZoneId.systemDefault()` dependency
   - Fix `DateTimeFunctionTest.testFromUnixtimeFunctionWithIntegerInput` weak 
`assertNotNull` replaced with exact value assertion under pinned UTC timezone
   
   **Charset safety:**
   - Replace `.getBytes()` (JVM default charset) with 
`.getBytes(StandardCharsets.UTF_8)` in `SystemFunctionTest`, 
`FieldEncryptTransformTest`, `AesGcmEncryptorTest`, `DoubaoMultimodalModelTest`
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. Test-only changes.
   
   ### How was this patch tested?
   
   ```bash
   ./mvnw -pl seatunnel-transforms-v2 test
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to