DanielLeens commented on code in PR #11000:
URL: https://github.com/apache/seatunnel/pull/11000#discussion_r3368554801
##########
seatunnel-engine/seatunnel-engine-client/src/test/java/org/apache/seatunnel/engine/client/SeaTunnelEngineClusterRoleTest.java:
##########
@@ -454,12 +462,14 @@ public void
testWorkerIsFirstMemberThenGetJobDetailStatus() {
.listJobStatus(true)
.contains("RUNNING")));
jobClient.cancelJob(jobId);
- await().pollDelay(10000, TimeUnit.MILLISECONDS)
- .atMost(60000, TimeUnit.MILLISECONDS)
+ await().atMost(120000, TimeUnit.MILLISECONDS)
.untilAsserted(
- () ->
- Assertions.assertEquals(
- "CANCELED",
jobClient.getJobStatus(jobId)));
+ () -> {
+ String status = jobClient.getJobStatus(jobId);
+ Assertions.assertTrue(
+ "CANCELED".equals(status) ||
"FAILED".equals(status),
+ "Expected terminal state but was: " +
status);
+ });
Review Comment:
Thanks for the update. I rechecked the latest head, and this thread is
resolved from my side. The test now goes back to asserting `CANCELED` on this
normal cancel path, while the broader flaky-test cleanup remains in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
