dheerusri324 commented on PR #11053:
URL: https://github.com/apache/seatunnel/pull/11053#issuecomment-4671366093
Hi @GabrielBBaldez, as @DanielLeens mentioned, I was testing this locally
and hit the exact same MongodbConnectorException blocker.
The issue is that the actual builder guard was never updated to accept the
new mode. The fix is right inside MongodbSourceConfigProvider.java (which isn't
in your PR yet).
If you update MongodbSourceConfigProvider.java with this snippet, it
bypasses the block:
public Builder startupOptions(StartupConfig startupOptions) {
this.startupOptions = Objects.requireNonNull(startupOptions);
if (startupOptions.getStartupMode() != StartupMode.INITIAL
&& startupOptions.getStartupMode() !=
StartupMode.TIMESTAMP
&& startupOptions.getStartupMode() !=
StartupMode.LATEST) { // <-- Add LATEST bypass here
throw new MongodbConnectorException(
ILLEGAL_ARGUMENT,
"Unsupported startup mode " +
startupOptions.getStartupMode());
}
return this;
}
If you patch that in, plus the test regression Daniel asked for, this should
be good to merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
