GabrielBBaldez commented on PR #11057: URL: https://github.com/apache/seatunnel/pull/11057#issuecomment-4680924615
Thanks for the thorough review, Daniel — all three points are fair. **1. Unrelated MongoDB-CDC commit:** done. I'd accidentally branched this off my MongoDB-CDC branch, so its commit rode along. Rebased onto `dev` — this PR now contains only the MySQL-CDC snapshot-mode commit. **2. Consistency closure:** you're right, and this is the important one. Skipping the incremental phase entirely drops the catch-up that reconciles changes occurring *during* the snapshot scan, so concurrent writes on a busy table can be lost. I'll rework it so snapshot-only still runs a **bounded** incremental phase that closes the snapshot/changelog window before finishing, instead of short-circuiting it — most likely by routing through the existing bounded-stop machinery so the guarantee matches `initial` semantics rather than introducing a new code path. **3. Concurrent-change coverage:** agreed — I'll add an e2e that injects changes while the snapshot is still in progress, so the mode has a real regression guard for exactly that window. I've converted this to a draft while I rework it, and I'll ping you for re-review once the bounded catch-up and the concurrent-change test are in. Thanks again for catching the consistency gap before it shipped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
