DanielLeens commented on PR #11058:
URL: https://github.com/apache/seatunnel/pull/11058#issuecomment-4688650805
Addressed the remaining review findings in the latest push (`ff8d6d2732`):
1. Fixed the HTTP recipe plugin install name in both EN and ZH docs.
- `http-to-jdbc` now uses `connector-http-base`, which matches:
- `config/plugin_config`
- `plugin-mapping.properties` (`seatunnel.source.Http =
connector-http-base`)
2. Fixed the quick-start output sample in both EN and ZH docs.
- `quick-start-seatunnel-engine` now shows:
- `output rowType: new_name<STRING>, age<INT>`
- This matches `FieldMapperTransform.transformTableSchema()` using the
mapped value as the output field name.
Validation for this follow-up push:
- `./mvnw spotless:apply`
- Passed.
- `./mvnw -q -DskipTests verify`
- Still fails locally at `seatunnel-dist` `export-connector-metadata` with
the same environment-level metadata export error:
- `org/apache/seatunnel/api/table/factory/TableSinkFactory`
- Website preview validation:
- Reused
`/Users/stone/work/myworkspace/seatunnel-website.worktrees/f867-doc-preview3.sZWOZW`
- `npm run build`
- Passed and generated both `build/` and `build/zh-CN/`
- `npm run serve -- --host 127.0.0.1 --port 3100`
- Browser-verified these updated pages:
- `/docs/getting-started/recipes/http-to-jdbc`
- `/zh-CN/docs/getting-started/recipes/http-to-jdbc`
- `/docs/getting-started/locally/quick-start-seatunnel-engine`
- `/zh-CN/docs/getting-started/locally/quick-start-seatunnel-engine`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
