davidzollo commented on PR #10058: URL: https://github.com/apache/seatunnel/pull/10058#issuecomment-4698628967
Hi @liujishui87, Thank you again for spending time on this PostgreSQL CDC issue, and also for following up through several review rounds. The direction of this PR was helpful and it pushed the discussion forward. After rechecking it against the current `dev` branch, this PR has now been superseded by a later fix in [#10843](https://github.com/apache/seatunnel/pull/10843). That follow-up resolved the same snapshot schema lookup problem in a more compatible way across different pgjdbc metadata behaviors, and it also added regression coverage for the catalog / non-catalog lookup paths. Because of that, keeping this PR open would mostly duplicate code that is already in `dev`, and the branch is also in conflict with the current target branch. To keep the review queue clean and avoid asking you to rework something that has effectively already been absorbed, we’re going to close this one. Please don’t take this as your contribution not being valuable. Your PR helped surface the problem clearly and contributed to the final solution path. Thanks again for the work and patience here. We’d be very happy to see more contributions from you in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
