DanielLeens commented on PR #11095: URL: https://github.com/apache/seatunnel/pull/11095#issuecomment-4717812542
Thanks for adding this detailed follow-up. I checked the `DynamicCompileTransformFactory` point you called out, and I agree the missing-key path is still a real validation regression on the current head, not just a test gap. +1 to @zhangshenghang's point here: the contributor should address that conditional-required gap before this PR moves forward. Since there is no new commit yet, I am not starting another full review round on the unchanged head right now, but I am happy to re-review the latest code once an update is pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
