DanielLeens commented on code in PR #11104:
URL: https://github.com/apache/seatunnel/pull/11104#discussion_r3427673493
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/TaskExecutionService.java:
##########
@@ -753,26 +599,82 @@ private void updateMetricsContextInImap() {
return;
}
+ HashMap<TaskLocation, SeaTunnelMetricsContext> localMetricsMap =
collectLocalMetricsMap();
+ long invocationStartNanos = System.nanoTime();
Review Comment:
Thanks for calling this out. I agree with moving `invocationStartNanos`
above `collectLocalMetricsMap()`, and the latest head now does exactly that in
`TaskExecutionService.updateMetricsContextInImap(...)`. With that change, the
exported latency matches the updated docs and now covers both local metrics
collection and the worker-to-master invocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
