DanielLeens commented on issue #10530: URL: https://github.com/apache/seatunnel/issues/10530#issuecomment-4760501205
Thanks for writing this up so clearly. I checked the current `AbstractJdbcCatalog.close()` path, and this looks like a genuine bug. Right now the close loop stops on the first `SQLException`, which means the remaining cached JDBC connections are never even attempted. For a catalog instance that has already opened connections for multiple database URLs, that can leave part of the connection map unclosed and turn one close failure into a broader resource leak. The most reasonable fix direction is the one you described: 1. attempt to close every cached connection 2. collect close failures instead of exiting on the first one 3. throw one aggregated exception at the end, preserving the rest as suppressed exceptions That keeps the cleanup behavior much safer without hiding the actual failure. This should stay open as a real bug. We've labeled it as `help wanted`, and a focused PR would be very welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
