DanielLeens commented on issue #11041: URL: https://github.com/apache/seatunnel/issues/11041#issuecomment-4760502442
Thanks for picking this up. I checked the current Oracle CDC path, and your proposed first slice is aligned with the right implementation boundary. In particular, this issue should stay centered on: 1. adding an explicit Oracle-owned SCN config surface 2. mapping that SCN into the connector's redo-log offset model instead of treating it as a loose runtime flag 3. failing early for invalid or unsupported combinations 4. making sure checkpoint / restore keeps the SCN-derived startup state intact The existing Oracle path already has the right conceptual anchor points for this work, including `OracleSourceConfigFactory`, `RedoLogOffset`, and `RedoLogOffsetFactory`, so keeping the first PR narrow around those parts makes sense. One thing I would strongly keep explicit in the first patch: if the configured SCN is unusable for the selected backend or no longer visible, startup should fail clearly rather than silently falling back to another behavior. Your proposed test scope also looks right for a first delivery. Please go ahead with a draft PR when ready and link it back here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
