DanielLeens opened a new pull request, #11153:
URL: https://github.com/apache/seatunnel/pull/11153

   ## What does this PR do?
   
   This PR stabilizes the JDBC schema-evolution add-columns checks that are 
currently blocking unrelated PRs.
   
   The non-exactly-once path was asserting row contents before the sink table 
metadata had fully caught up after `add_columns`. In CI this shows up as stale 
sink rows such as `scooter` still being returned where the add-columns case 
expects the later `hawk9821` data.
   
   This change:
   - waits for source and sink column lists to match before asserting 
add-columns data
   - reuses the same add-columns data assertion helper in both exactly-once and 
non-exactly-once paths
   - keeps the scope limited to the shared JDBC schema-evolution test base
   
   ## Validation
   
   - `./mvnw -pl 
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-ddl
 -am -nsu -Dskip.ui=true spotless:apply`
   - `./mvnw -f 
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-ddl/pom.xml
 -nsu -Dskip.ui=true -Dmaven.gitcommitid.skip=true -DskipUT=true -DskipIT=false 
-DfailIfNoTests=false -Dit.test=DmSchemaChangeIT,SqlServerSchemaChangeIT verify`
   
   Notes:
   - `seatunnel-engine-ui` was skipped because this PR does not touch UI 
modules.
   - Real IT validation was attempted twice. The `/Volumes/disk2/...` worktree 
is on `exfat,noowners`, which makes the MySQL init resource path unusable for 
Testcontainers. Retrying from a Docker-shared POSIX path reached real container 
execution, but the local host environment then hit 
`SeaTunnelContainer.getJobStatus()` `Connection reset` errors for both 
`DmSchemaChangeIT` and `SqlServerSchemaChangeIT` before the add-columns 
assertions were reached. This host-specific runtime issue is separate from the 
CI assertion failures this PR addresses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to