zhaoysg commented on PR #11113: URL: https://github.com/apache/seatunnel/pull/11113#issuecomment-4764078813
Thanks for the careful re-review. I pushed an update in `fbf56053d`. Changes in this update: - Added backward-compatible normalization for `TiDBSourceCheckpointState.pendingSplit` so an older checkpoint state shaped as `Map<Integer, TiDBSourceSplit>` is restored into the new `Map<Integer, List<TiDBSourceSplit>>` representation. - Added a focused restore-compatibility regression test covering that legacy single-split pending map shape and verifying the restored enumerator can reassign it. - Removed the JDBC diagnostics change from this PR, so the PR diff is now focused on TiDB CDC again and no longer touches `connector-jdbc` relative to the PR base. One clarification on the JDBC point: after checking the PR diff against the base, the `batchIntervalMs`-triggered `writeRecord` flush path was already present on the base branch; this PR had only added flush diagnostics in `JdbcOutputFormat`. Still, I agree it was unnecessary scope for this TiDB fix, so I removed it from this PR. Local verification: ```bash ./mvnw -DspotlessFiles=seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/tidb/source/enumerator/TiDBSourceCheckpointState.java,seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/tidb/source/enumerator/TiDBSourceSplitEnumeratorTest.java,seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcOutputFormat.java spotless:check ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb -DskipIT -Dskip.spotless=true -Dcheckstyle.skip=true -Dtest=TiDBSourceReaderTest,TiDBSourceSplitEnumeratorTest test ``` The focused TiDB tests pass locally: 4 tests, 0 failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
