nzw921rx opened a new pull request, #11160:
URL: https://github.com/apache/seatunnel/pull/11160
### Purpose of this pull request
`PulsarSinkFactory` implements `SupportMultiTableSinkWriter` but its
`optionRule()` did not declare
`SinkConnectorCommonOptions.MULTI_TABLE_SINK_REPLICA` as an optional parameter,
causing `ConnectorSpecificationCheckTest` to fail:
```
org.opentest4j.AssertionFailedError: Please add
`SinkCommonOptions.MULTI_TABLE_SINK_REPLICA` optional into the `optionRule`
method optional of `PulsarSinkFactory` ==> expected: <true> but was: <false>
at
org.apache.seatunnel.api.connector.ConnectorSpecificationCheckTest.checkSupportMultiTableSink(ConnectorSpecificationCheckTest.java:185)
at
org.apache.seatunnel.api.connector.ConnectorSpecificationCheckTest.testAllConnectorImplementFactoryWithUpToDateMethod(ConnectorSpecificationCheckTest.java:172)
```
### Changes
- Added `SinkConnectorCommonOptions.MULTI_TABLE_SINK_REPLICA` to the
`.optional(...)` list in `PulsarSinkFactory.optionRule()`
### How was this patch tested?
```bash
./mvnw test -pl seatunnel-dist
-Dtest=ConnectorSpecificationCheckTest#testAllConnectorImplementFactoryWithUpToDateMethod
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
