LeonYoah opened a new pull request, #11166: URL: https://github.com/apache/seatunnel/pull/11166
### Purpose of this pull request Fixes #10992. Postgres CDC should not depend on a localized error message to detect an existing replication slot. This PR keeps the SQLState `42710` check and moves it into a helper, with the old English message check as a fallback. Basis: - PostgreSQL documents `42710` as `duplicate_object` in [PG 13](https://www.postgresql.org/docs/13/errcodes-appendix.html) and [current PG](https://www.postgresql.org/docs/current/errcodes-appendix.html). - PostgreSQL replication slot creation reports a duplicate slot name with `ERRCODE_DUPLICATE_OBJECT`: [slot.c](https://github.com/postgres/postgres/blob/master/src/backend/replication/slot.c#L2976-L2982). ### Does this PR introduce _any_ user-facing change? Yes. When the replication slot already exists and PostgreSQL returns a localized message, Postgres CDC logs a warning and continues. ### How was this patch tested? ``` JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-8.jdk/Contents/Home ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-postgres -am -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -Dlicense.skip=true -DskipTests install ``` ``` JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-8.jdk/Contents/Home ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-postgres -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -Dlicense.skip=true -Dtest=PostgresSourceFetchTaskContextTest test ``` ``` JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-8.jdk/Contents/Home ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-postgres -DskipITs -Dcheckstyle.skip -Dlicense.skip=true spotless:check git diff --check ``` Local reproduction: - PG 13 zh_CN returned `sqlState=42710` and message `错误: 复制槽名 "seatunnel" 已经存在`. - Before the fix, SeaTunnel failed at `PostgresSourceFetchTaskContext`. - After the fix, SeaTunnel logged the existing-slot warning, entered incremental mode, and Console received `INSERT : 4, delta_fix`. - PG 18.3 also returned `sqlState=42710` for a duplicated replication slot. ### Check list * [x] If any new Jar binary package adding in your PR, please add License Notice according [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md) * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs * [x] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR. * [x] If you are contributing the connector code, please check that the following files are updated: 1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it 2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml) 3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml) 4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/) 5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
