DanielLeens opened a new pull request, #11169:
URL: https://github.com/apache/seatunnel/pull/11169
## Purpose of this pull request
This PR fixes JDBC catalog validation failures that are unrelated to the
triggering PR changes but currently break CI jobs such as the SQL Server XA
schema evolution workflow.
Two compatibility gaps were causing submission-time validation to reject
valid sink/catalog configurations:
- Oracle thin service URLs such as `jdbc:oracle:thin:@host:1521/ORCLCDB`
were checked only by the generic JDBC URL parser.
- SQL Server and compatible dialects that provide the database through the
explicit `database` option were rejected when the URL itself did not embed a
database name.
## Does this pull request introduce _any_ user-facing change?
Yes. Valid JDBC catalog and sink configurations that already provide the
database through dialect-specific URL formats or the explicit `database` option
now pass validation again.
## How was this patch tested?
Validation run in
`/Volumes/disk2/work/myworkspace/tmp/seatunnel-dev-pulsar-multi-table-replica-20260623`:
- `./mvnw spotless:apply -pl seatunnel-connectors-v2/connector-jdbc`
- `./mvnw -pl seatunnel-connectors-v2/connector-jdbc -DskipTests compile`
- Manual focused test compilation:
- `javac -cp "$(cat /tmp/seatunnel-jdbc-test.cp)" -d
/tmp/seatunnel-jdbc-manual-test-classes ...JdbcCatalogFactoryTest.java
...JdbcCatalogUtilsTest.java`
- Focused JUnit execution:
- `java -jar
~/.m2/repository/org/junit/platform/junit-platform-console-standalone/1.9.0/junit-platform-console-standalone-1.9.0.jar
-cp "/tmp/seatunnel-jdbc-manual-test-classes:$(cat
/tmp/seatunnel-jdbc-test.cp)" -c
org.apache.seatunnel.connectors.seatunnel.jdbc.catalog.JdbcCatalogFactoryTest
-c org.apache.seatunnel.connectors.seatunnel.jdbc.utils.JdbcCatalogUtilsTest
--details=tree --disable-banner`
Additional repo-path verification attempted:
- `./mvnw -q -pl seatunnel-connectors-v2/connector-jdbc -DskipTests verify`
That `verify` run is still blocked by an unrelated existing `testCompile`
failure in `DuckDBSourceAndSinkTest` due missing
`org.apache.seatunnel.connectors.seatunnel.sink/source` imports.
`seatunnel-engine-ui` was not revalidated because this change only affects
JDBC connector validation and catalog option propagation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
