ss666 opened a new pull request, #11195:
URL: https://github.com/apache/seatunnel/pull/11195
### Purpose of this pull request
Before working on the Redis connector changes for #11007, I reviewed the
connector and found the source/sink `OptionRule`s were out of sync with the
docs and with the options each side actually reads. This small, self-contained
PR fixes them ahead. No new feature behavior, no public option key/default
change.
main changes:
1. `RedisSinkFactory`: add `db_num`, `batch_size`, `field_delimiter` to the
sink rule — they are documented and read when building the sink, but were
missing.
2. `RedisSourceFactory`: remove sink-only `key` (`KEY`) that the source
never reads.
3. `RedisTableConfig`: merge the two duplicate required-field validators
into one applied uniformly to single-table and `tables_configs` modes, and
merge the two ~95%-identical builders into one `buildTableConfig`.
4. add `RedisTableConfigTest` covering required-field validation and table
building on both single-table and multi-table modes.
### Does this PR introduce _any_ user-facing change?
No runtime/job behavior change. Conforming configs that follow the docs are
unaffected.
### How was this patch tested?
Scoped to the `connector-redis` module (the only module this PR changes):
- `./mvnw spotless:apply` pass.
- `./mvnw test -pl seatunnel-connectors-v2/connector-redis` → 28/28, 0
failures
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
