DanielLeens commented on PR #10900: URL: https://github.com/apache/seatunnel/pull/10900#issuecomment-4814492461
Thanks for the ping, and I took another look at the current failing Build jobs. From the latest logs, I still do not see a failure path that goes through the syslog source code in this PR: - `all-connectors-it-3 (8, ubuntu-latest)` is failing in `SqlServerCDCIT.testWithSchemaEvolution[4]` with a SQL Server CDC metadata update deadlock (`SQLServerException`, error 1205). - `jdbc-connectors-it-part-7 (11, ubuntu-latest)` is failing in `JdbcIrisIT` startup with an Awaitility timeout. Those are both in unrelated E2E suites, and neither one is exercising the new syslog runtime path reviewed in this PR. I also re-checked the current `dev` head locally, and I do not see evidence that this PR introduced those failures. So my review status on the code itself does not change here. If a maintainer is comfortable treating these as unrelated CI failures, I would be fine keeping the approval and handling the two failing jobs separately. If the jobs are rerun after the unrelated flakes are addressed, I am happy for this PR to move forward from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
