PDGGK commented on PR #10532: URL: https://github.com/apache/seatunnel/pull/10532#issuecomment-4829655744
Yes, still active — thanks for the nudge, @zhangshenghang. I've just pushed the unit tests the review asked for: - `AbstractJdbcCatalogCloseTest` covers the JDBC fix (#10530): `close()` attempts to close every pooled connection even when some fail, aggregates the failures via `addSuppressed()`, and always clears the connection map. - `AbstractReadStrategyGzCloseTest` covers the file fix (#10531): the GZ branch releases the underlying input stream through try-with-resources (the stream stays open on the pre-fix code path). The concurrent-modification note from the earlier review is a pre-existing design concern unrelated to this leak fix, so I've left it for a follow-up as suggested. I'm happy to also add the JavaDoc/logging touch-ups in this PR if you'd like them here. PTAL when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
