nzw921rx opened a new pull request, #11228:
URL: https://github.com/apache/seatunnel/pull/11228
### Purpose of this pull request
This pull request fixes distorted conditional validation errors in
`seatunnel-api`.
- Remove the `try/catch` wrapping from `ConditionEvaluators#evaluate`, which
was rewriting `OptionValidationException` thrown by the `EXTENSION` operator
during conditional evaluation.
- Catch `OptionValidationException` at the `ConditionRule` level in
`ConfigValidator` so the aggregated validation error is reported against the
full conditional expression context.
### Does this PR introduce _any_ user-facing change?
Yes. When an `EXTENSION` condition throws `OptionValidationException` inside
a conditional rule, the original validation message is now preserved and
reported against the whole condition expression instead of being rewritten at
the per-condition level.
### How was this patch tested?
```bash
./mvnw spotless:apply
./mvnw -q -DskipTests verify
./mvnw -pl seatunnel-api -Dtest=ConfigValidatorTest test
```
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]