DanielLeens commented on PR #11225: URL: https://github.com/apache/seatunnel/pull/11225#issuecomment-4845283838
Thanks for raising this, @nzw921rx. I traced the Redis validation path again from the factory `optionRule()` into the runtime config builders. From my side, the current PR is still mainly a submit-time validation migration: the meaningful risk surface is whether invalid shapes are rejected on the real factory submission path, and the added unit coverage already exercises that path deterministically. Because of that, I would treat broader E2E coverage for more configuration combinations as a useful follow-up, but not as a merge blocker for this specific migration PR. Separately, this branch is currently behind the latest `dev` (`behind_by=15`, compare status: `diverged`) and the latest `Build` is still pending. The lowest-cost next step for the author is to sync with the latest `dev` and rerun CI first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
