julianbradford19-png commented on issue #11221: URL: https://github.com/apache/seatunnel/issues/11221#issuecomment-4858244543
Thanks for the feedback and for defining the clear scope for this PR. I agree with focusing the initial change on adding copy support for timestamp_tz, the vector families, and multiple_row, along with the necessary unit tests for each type. I will look into whether the E2E coverage can be efficiently integrated into this PR or if it should be handled as a separate follow-up task. I'll proceed with the implementation based on this direction. On Mon, Jun 29, 2026, 8:06 PM Daniel ***@***.***> wrote: > *DanielLeens* left a comment (apache/seatunnel#11221) > <https://github.com/apache/seatunnel/issues/11221#issuecomment-4838950361> > > Thanks for opening this with a concrete scope. > > This reads like a useful enhancement rather than a bug. The direction > makes sense: CopyTransform should not lag behind the data types that are > already first-class in the rest of the pipeline, and the missing test > coverage is also worth fixing at the same time. > > Since you already volunteered to submit a PR and the issue is assigned, I > would suggest keeping the first change focused on two things: > > 1. add the missing copy support for timestamp_tz, the vector families, > and multiple_row > 2. add solid unit coverage for each newly supported type so the > behavior is locked down > > If E2E coverage can reuse an existing transform test path without making > the PR too heavy, that would be great as a follow-up in the same change or > the next one. > > So from my side, this is a reasonable feature to keep open and continue > through PR review. Thanks for driving it. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/seatunnel/issues/11221?email_source=notifications&email_token=B74KUG57ZBUNP3544AYNMW35CMG7RA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBTHA4TKMBTGYY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-4838950361>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/B74KUGY7AIPRDJDT7RIBCLD5CMG7RAVCNFSNUABEKJSXA33TNF2G64TZHM4TSNBRGIZTAOB3JFZXG5LFHM2DONRZGUYDQOBTGCQXMAQ> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/B74KUG5DZR3LWNJM5IWN5BD5CMG7RA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBTHA4TKMBTGYY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ> > and Android > <https://github.com/notifications/mobile/android/B74KUG4LSY6LNIMOY4WFBND5CMG7RA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBTHA4TKMBTGYY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>. > Download it today! > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
