yzeng1618 commented on PR #11176:
URL: https://github.com/apache/seatunnel/pull/11176#issuecomment-4861915443
Thanks for the cleanup — deprecation direction looks good, and the
placeholder path is indeed resolved in TablePlaceholderProcessor before sink
creation, so it maps onto the normal path for the common case.
One caveat worth noting: ${table_name} and tablePrefix/tableSuffix aren't
strictly equivalent. ${table_name} resolves to identifier.getTableName() (pure
name, no dot), but the resolved table then goes through
sinkTableNameBefore.split("\\.") in JdbcSinkFactory, which re-derives schema by
dots — whereas prefix/suffix are plain concatenation and never re-trigger
schema inference. So for dotted/opaque table names the two paths diverge (same
class of issue #11220 fixed for Kafka source; that fix isn't mirrored here).
Fine to merge as a deprecation-only change (runtime untouched, fully
backward compatible). Two non-blocking follow-ups: (1) docs should state the
equivalence boundary — use ${schema_name}.${table_name} for schema-qualified
targets, with a dotted-name caveat; (2) a small UT asserting both forms yield
the same TableIdentifier. And keep "deprecate" decoupled from "remove" until
the dotted-name case is actually covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
