DanielLeens opened a new issue, #11273:
URL: https://github.com/apache/seatunnel/issues/11273

   ## Background
   
   The current JDBC sink documentation explains `primary_keys`, generated sink 
SQL, and sink option placeholders such as `${primary_key}`. It also documents 
common JDBC sink behavior around upsert, COPY, and inherited upstream catalog 
keys.
   
   However, users still ask whether a generated placeholder can be mixed with 
additional static key names, for example:
   
   ```hocon
   primary_keys = ["${primary_key}", "tenant_id"]
   ```
   
   The current docs show `primary_keys = ["${primary_key}"]`, but do not 
clearly state whether mixing placeholders and literal column names is 
supported, how the placeholder expands, or what happens when the expanded key 
list overlaps with a static key.
   
   ## Goal
   
   Clarify the supported behavior of JDBC sink `primary_keys` when using sink 
option placeholders together with literal column names.
   
   ## Suggested scope
   
   Please update the relevant English and Chinese docs, most likely:
   
   - `docs/en/introduction/configuration/sink-options-placeholders.md`
   - `docs/zh/introduction/configuration/sink-options-placeholders.md`
   - `docs/en/connectors/sink/Jdbc.md`
   - `docs/zh/connectors/sink/Jdbc.md`
   
   The update should explain:
   
   1. Whether `primary_keys` supports mixing `${primary_key}` with static 
column names.
   2. Whether `${primary_key}` expands to one or more key columns.
   3. How duplicates should be handled if a static column is already included 
in the placeholder expansion.
   4. Whether the behavior differs for single-table and multi-table jobs.
   5. A small valid example and, if unsupported, a small invalid example.
   
   ## Acceptance criteria
   
   - The docs give a direct yes/no answer for mixed placeholder + static 
primary key configuration.
   - The docs include at least one HOCON example.
   - English and Chinese docs are consistent.
   - The documented behavior is verified against the current implementation 
rather than inferred from examples only.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to