dybyte commented on PR #10506:
URL: https://github.com/apache/seatunnel/pull/10506#issuecomment-4889437640
> ```java
> try {
> invoke.get();
> notifyStateSuccess = true;
> } catch (InterruptedException e) {
> logger.severe("send notify task status failed", e);
> } catch (JobNotFoundException e) {
> logger.warning("send notify task status failed because
can't find job", e);
> notifyStateSuccess = true;
> } catch (JobRestoreInProgressException e) {
> logger.info(ExceptionUtils.getMessage(e));
> logger.info(
> String.format(
> "notify the job of the task(%s) status
failed, retry in %s millis",
> taskGroupLocation, sleepTime));
> try {
> Thread.sleep(sleepTime);
> } catch (InterruptedException ex) {
> Thread.currentThread().interrupt();
> logger.severe(e);
> }
> } catch (ExecutionException e) {
> if (e.getCause() instanceof JobNotFoundException) {
> logger.warning("send notify task status failed because
can't find job", e);
> notifyStateSuccess = true;
> } else {
> logger.warning(ExceptionUtils.getMessage(e));
> logger.warning(
> String.format(
> "notify the job of the task(%s) status
failed, retry in %s millis",
> taskGroupLocation, sleepTime));
> try {
> Thread.sleep(sleepTime);
> } catch (InterruptedException ex) {
> Thread.currentThread().interrupt();
> logger.severe(e);
> }
> }
> }
> }
> ```
>
> I have concerns about the retry logic in the restore scenario here. I
believe that users deployed on the k8s cluster will inevitably encounter
cluster upgrades, and when the Seattunnel cluster restarts a large number of
tasks for restore, it will consume a lot of Hazelcast thread resources.
Therefore, I think a retry limit should be added in this scenario
The worker already has the same outer retry loop for generic notify failures
before this patch. If there is a problem with this specific logic, it should be
handled in a separate issue or PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
