DanielLeens commented on issue #11306:
URL: https://github.com/apache/seatunnel/issues/11306#issuecomment-4912413261

   Thanks @goutamadwant, PR #11377 is the right place to continue this fix.
   
   The first-pass scope matches the issue well: keep it focused on the SftpFile 
binary submit-time path, where config creation currently pays the expensive 
discovery cost before the job is created.
   
   For review, the two compatibility points I would keep especially visible are:
   1. non-binary file formats that still need eager discovery for schema 
inference should not be changed accidentally
   2. both `full` and `update` mode should still apply the same filtering / 
target-path semantics after discovery moves later
   
   It would also be useful for the PR description or test evidence to show the 
before/after boundary clearly: config creation should no longer do the full 
SFTP listing for the binary path, and discovery should happen when the 
enumerator opens.
   
   Let's keep this issue open until #11377 is merged and the reporter has a 
chance to validate the behavior with production-shaped sanitized logs/config if 
needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to