davidzollo commented on PR #10447: URL: https://github.com/apache/seatunnel/pull/10447#issuecomment-4915664670
I pushed a maintainer follow-up commit to this PR (`353db98a96`) to fix the HubSpot runtime wiring. The previous `HubSpotIT` failure was not just stale-base drift. The HubSpot source was building a custom parameter object, but the actual reader path still relied on the generic `HttpSource` runtime config, so the HubSpot-specific cursor pagination defaults were not consistently reaching the real reader path. This follow-up does four focused things: 1. Build a shared runtime config with HubSpot defaults (`format = JSON`, `content_field = $.results`, `keep_page_param_as_http_param = true`, and nested cursor paging defaults). 2. Reuse the HubSpot-specific parameter object in `createReader(...)` so the reader sees the injected auth header, resolved URL, and pagination settings together. 3. Add a regression test that asserts the runtime reader wiring for auth/url/page info/content field. 4. Align the HubSpot E2E configs with the JSON + schema path expected by `HttpSource`. Local verification I reran: - `./mvnw -pl seatunnel-connectors-v2/connector-http/connector-http-hubspot,seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e -am spotless:apply -DskipTests -DskipITs -DskipUT=true -DskipIT=false -Dskip.ui=true` - `./mvnw -pl seatunnel-connectors-v2/connector-http/connector-http-hubspot -Dtest=HubSpotSourceFactoryTest,HubSpotSourceParameterTest,HubSpotSourceTest -DfailIfNoTests=false -Dspotless.check.skip=true -Dskip.ui=true test` I did not do a broad `update branch` / merge-from-`dev` in this pass. The PR is currently far behind `dev`, and a full branch sync would pull in a very large unrelated upstream delta. I wanted to keep this rescue focused on the actual HubSpot runtime bug first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
