det101 opened a new pull request, #11388:
URL: https://github.com/apache/seatunnel/pull/11388

   ## Purpose
   Extend JDBC sink `table_options` (SaveMode auto-create) from MySQL to TiDB 
and OceanBase MySQL mode, as a follow-up to #11101 / #11047.
   
   ## Changes
   - Extract shared MySQL-family key whitelist validation into 
`MysqlFamilyTableOptions` (`engine` / `charset` / `collate`)
   - Wire `OceanBaseMysqlDialect.validateTableOptions` and apply options in 
`OceanBaseMysqlCreateTableSqlBuilder` DDL
   - TiDB reuses `MysqlDialect` + `MySqlCatalog` DDL via `jdbc:mysql://` (no 
new dialect)
   - Docs (en/zh): support matrix + dialect caveats (TiDB ignores `engine`; 
OceanBase Oracle mode fail-fast; key-only validation at submit)
   - Unit tests: dialect/DDL/OptionRule coverage, including OceanBase Oracle 
negative case
   
   ## Non-goals
   - OceanBase Oracle-compatible mode remains unsupported (default dialect 
fail-fast)
   - No value-level charset/collation validation at submit (same as MySQL PR1)
   - PostgreSQL and other JDBC dialects deferred to later PRs
   
   ## Test plan
   - [x] `JdbcTableOptionsConditionExtensionTest` (TiDB / OceanBase MySQL pass; 
OceanBase Oracle reject)
   - [x] `OceanBaseMysqlDialectTest` / 
`OceanBaseMysqlCreateTableSqlBuilderTest` / `TiDBTableOptionsTest` / 
`MysqlDialectTest`
   - [ ] CI on this PR
   
   ## Related
   - Issue: #11047
   - MySQL: #11101
   - StarRocks: #11242
   
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to