DanielLeens commented on PR #11216: URL: https://github.com/apache/seatunnel/pull/11216#issuecomment-4944507206
Thanks for the ping. I rechecked the current head `9588de8b6ba9` and, from Daniel's side, my latest approval still stands on this unchanged revision. The compatibility gap I called out earlier is already fixed here: - the null check runs before the dynamic-field branch again, so the default `enable_nullable_field=false` behavior is preserved - the partition-key exclusion and the `tableExists()` guard are also on this head - the current `Build` is green: https://github.com/apache/seatunnel/runs/86194110067 So I do not have a new blocker from Daniel's side on the current head. Since @zhangshenghang raised one of the earlier compatibility concerns, they may still want to confirm their own point as well, but Daniel's review on this revision remains clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
