DanielLeens commented on PR #10837: URL: https://github.com/apache/seatunnel/pull/10837#issuecomment-4953585595
Thanks for the careful recheck here. I traced the same path on the current head and I agree this is a real blocker. The new early return in `AbstractJdbcSourceChunkSplitter.generateSplits(...)` now bypasses the old exactly-once guard for tables without a primary / unique key. In other words, `enable_concurrent_read=false` currently changes more than just the split strategy: it also opens a path that used to be rejected under `exactly_once=true`. So from Daniel's side I would treat this as a code-side blocker that still needs a follow-up commit. The safer fix is to keep the existing exactly-once validation in front of the new single-split shortcut, and only skip the expensive split analysis after that validation has already passed. Once that update is pushed, I'm happy to re-review the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
