det101 opened a new pull request, #11416: URL: https://github.com/apache/seatunnel/pull/11416
## Purpose Extend JDBC sink `table_options` (SaveMode auto-create) to Oracle, as a follow-up to #11047 / #11101 / #11388. ## Changes - Add Oracle curated key whitelist: `tablespace`, `pctfree` - Wire `OracleDialect.validateTableOptions` and apply options in `OracleCreateTableSqlBuilder` DDL (`PCTFREE` / `TABLESPACE`) - OceanBase Oracle mode inherits the same path via `OracleDialect` + `OceanBaseOracleCreateTableSqlBuilder extends OracleCreateTableSqlBuilder` (no separate OB Oracle implementation) - Docs (en/zh): support matrix + dialect caveats + Oracle example - Unit tests: dialect / DDL / OptionRule coverage (including OceanBase Oracle pass & unknown-key reject) ## Non-goals - Nested `STORAGE (...)`, LOB, or partition clauses - `ALTER TABLE` on existing tables (`table_options` only applies when SaveMode creates the table) - Value-level validation beyond key whitelist (same as MySQL delivery) - PostgreSQL (separate PR) ## Test plan - [x] `OracleDialectTableOptionsTest` - [x] `OracleCreateTableSqlBuilderTest#testBuildCreateTableSqlWithTableOptions` - [x] `JdbcTableOptionsConditionExtensionTest` (Oracle / OceanBase Oracle) - [x] `OceanBaseOracleCreateTableSqlBuilderTest` (regression) - [ ] CI on this PR ## Related - Issue: #11047 - MySQL: #11101 - TiDB / OceanBase MySQL: #11388 - StarRocks: #11242 Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
