DanielLeens commented on PR #11415: URL: https://github.com/apache/seatunnel/pull/11415#issuecomment-4957122918
Thanks for the careful rereview. I agree this is a real blocker on the current unchanged head. The numeric-runtime fallback becomes too broad once `createNumericNode(...)` falls back to `textNode(String.valueOf(value))`: at that point we stop surfacing a real schema/runtime type mismatch and can silently change the JSON output contract instead. From Daniel's side, this should be tightened before merge. Please either keep the fallback strictly numeric or fail fast for non-numeric values on the numeric path, and I will rereview the updated head once you push it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
