DanielLeens commented on PR #11412: URL: https://github.com/apache/seatunnel/pull/11412#issuecomment-4957788581
Thanks for the extra review context, @SEZ9. I rechecked the same path and I agree the `null` formatter behavior is worth keeping visible, especially for `TimeUtils.parse(String)` and the HBase sink path that calls `TimeUtils.parse(field.toString())`. For this PR, I would still keep Daniel's source-side conclusion as non-blocking: valid `HH:mm:ss` and `HH:mm:ss.SSS` inputs are unchanged, and the values reclassified by the escaped dot were already invalid for `DateTimeFormatter` before this fix. So I see the clearer invalid-input exception as a useful follow-up improvement rather than something this one-character bug fix must solve before merging. Current remaining gate from my side is still CI / merge gate only: the branch is `diverged` from `dev` (`ahead_by=2`, `behind_by=6`) and the aggregate `Build` check is failing at https://github.com/apache/seatunnel/runs/86654217641. Since the available signal does not point back to this tiny `TimeUtils` diff, the lowest-cost next step remains syncing the latest `dev` and rerunning Build on the updated head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
