DanielLeens commented on PR #11215: URL: https://github.com/apache/seatunnel/pull/11215#issuecomment-4968399540
Thanks @SEZ9 for the rereview. I rechecked `SeaTunnelServer` on the current head. I would respectfully push back on calling this a public API break. The delta here adds `clusterObservabilityService` plus member event hooks, but it does not remove or narrow an existing stable SeaTunnel external contract. `SeaTunnelServer` is an internal engine-server implementation constructed from `NodeExtension`, not a connector-facing or `seatunnel-api` surface. So from Daniel's side I do not see downstream connector compatibility being broken by this signature change itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
