DanielLeens commented on PR #11397: URL: https://github.com/apache/seatunnel/pull/11397#issuecomment-4968399593
Thanks for the detailed context. Given the current constraint, I would prefer the second option: add focused unit coverage for the vector conversion path now, and leave the E2E test for a follow-up once the vector-enabled YashanDB build is publicly available and runnable in CI. A skipped E2E would not really give us merge evidence on the current branch. When you update the PR, please make the unit tests cover the concrete vector types this branch claims to support, and mention clearly in the PR that the end-to-end validation depends on the unreleased database version. Once that update is pushed, I'm happy to re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
