DanielLeens commented on PR #10453:
URL: https://github.com/apache/seatunnel/pull/10453#issuecomment-4968420285
Rechecked the same unchanged head `eb19e6b04702` after the CI / merge-gate
fact changed.
## Runtime path rechecked
```text
MySQL-CDC schema-event path
-> MySqlTypeUtils.convertToSeaTunnelColumn(column, dbzConnectorConfig)
-> column.typeName().toUpperCase()
-> if "SET UNSIGNED", normalize dataType to "SET"
-> MySqlTypeConverter.convert(typeDefine)
-> SET maps to STRING
MySQL catalog startup path from the earlier blocker
-> MySqlCatalog.buildColumn(resultSet)
-> dataType = DATA_TYPE.toUpperCase(), for example SET
-> unsigned = COLUMN_TYPE.toLowerCase().contains("unsigned")
-> BasicTypeDefine(dataType=SET, unsigned=true)
-> MySqlTypeConverter.convert(typeDefine)
-> appends " UNSIGNED" when unsigned=true
-> latest head now handles MYSQL_SET_UNSIGNED
-> STRING column is produced instead of COMMON-17 / unsupported
convert type
```
## Merge conclusion
### Conclusion: source blocker cleared from Daniel's side; waiting for the
current gate
1. Blocking items
- None from Daniel's source review on this unchanged head.
2. Current gate
- The current remaining gate is still pending: `PENDING gate: Build`
(https://github.com/apache/seatunnel/runs/87047747477)
- Daniel only has `READ` permission on this repository, so a write-capable
maintainer may still need to handle the final approval / dismissal step once
the gate is clear.
I do not see a reopened code-side blocker from Daniel on the current head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
