DanielLeens commented on PR #10986:
URL: https://github.com/apache/seatunnel/pull/10986#issuecomment-4968422907
Rechecked the current head `1d1397232afc` against the latest `dev` after the
CI / merge-gate fact changed.
## Runtime path rechecked
```text
bounded source
-> AzureDataExplorerSplitEnumerator.run()
-> create single split `adx-query`
-> AzureDataExplorerSourceReader.pollNext()
-> splitQueue.poll()
-> executeQuery()
-> emit all rows in one pass
-> snapshotState()
-> only persists remaining splitQueue
sink path
-> AzureDataExplorerSinkWriter.write()
-> serializer.toCsvLine(row)
-> buffer rows
-> flush()
-> concatenate CSV lines
-> ingestFromStream(...)
```
## Merge conclusion
### Conclusion: still needs fixes before merge
1. Blocking items
- The source-side blockers from my previous Daniel review still stand on
this unchanged head.
- Separately, this branch is behind upstream (`compare status: diverged`,
`ahead_by=5`, `behind_by=309`), and the current failing gate is `FAILURE gate:
Build`: https://github.com/apache/seatunnel/runs/78684187561
- GitHub is also reporting merge conflicts with the latest base, so please
resolve those as part of the sync step first.
2. Lowest-cost next step
- Please sync with the latest `dev` and rerun the failing gate first so we
can separate baseline CI noise from the remaining code-side fixes.
- After that, if the same source blocker is still unresolved, I would still
keep this PR out of merge-ready state from Daniel's side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
