DanielLeens commented on PR #11326:
URL: https://github.com/apache/seatunnel/pull/11326#issuecomment-4968427615
Rechecked the same unchanged head `df8459556ff5` after the CI / merge-gate
fact changed.
## Runtime path rechecked
```text
StarRocks source docs
-> StarRocksSourceOptions
-> scan_connect_timeout_ms defaultValue(1000)
-> scan_mem_limit defaultValue(1024 * 1024 * 1024L)
-> StarRocksSourceFactory.optionRule()
-> schema is optional
-> table and table_list are exclusive
-> StarRocksSourceTableConfig
-> parses top-level schema for single-table mode
-> parses per-entry schema inside table_list for multi-table mode
S3/Sftp schema-evolution docs
-> S3FileSinkFactory.optionRule()
-> no schema_evolution_enabled option
-> SftpFileSinkFactory.optionRule()
-> no schema_evolution_enabled option
-> BaseMultipleTableFileSink
-> implements SupportMultiTableSink, not SupportSchemaEvolutionSink
-> MultiTableSink.supports()
-> only advertises schema evolution when the sub-sink implements
SupportSchemaEvolutionSink
-> BaseFileSinkWriter
-> does not implement SupportSchemaEvolutionSinkWriter
-> falls back to SinkWriter.applySchemaChange(), which is the default
no-op
```
## Merge conclusion
### Conclusion: source blocker cleared from Daniel's side
1. Blocking items
- None from Daniel's source review on this unchanged head.
2. Current gate
- The current CI signal is now green:
https://github.com/apache/seatunnel/actions/runs/28986125869/job/86015535498
- Daniel only has `READ` permission on this repository, so GitHub may still
show earlier review state and a write-capable maintainer may still need to
handle the final approval / dismissal step.
I do not see a reopened code-side blocker from Daniel on the current head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
