DanielLeens commented on PR #10990:
URL: https://github.com/apache/seatunnel/pull/10990#issuecomment-4968423380
Rechecked the same unchanged head `74ba70f22665` after the CI / merge-gate
fact changed.
## Runtime path rechecked
```text
Knowledge Sync contract
-> KnowledgeSyncMetadataField [KnowledgeSyncMetadataField.java:23-59]
-> defines logical keys such as DocumentId / ChunkHash
-> maps them to canonical physical names such as document_id /
chunk_hash
Metadata registration
-> MetadataUtil.METADATA_FIELDS [MetadataUtil.java:39-50]
-> CommonOptions metadata
-> + KnowledgeSyncMetadataField values
-> MetadataUtil.isMetadataField(fieldName) [122-123]
Metadata transform config parsing
-> MetadataTransform.initOutputFields(...) [55-73]
-> accepts the new Knowledge Sync logical keys
-> still rejects unknown metadata keys
Output schema generation
-> MetadataTransform.getOutputColumns() [92-123]
-> requires metadataSchema.contains("DocumentId")
-> renames the metadata column to the configured output field
Runtime projection
-> MetadataTransform.getMetadataFieldValue(...) [126-137]
-> reads inputRow.getOptions().get("DocumentId")
-> reads inputRow.getOptions().get("ChunkHash")
Closest existing built-in producer path in this repo
-> MarkdownReadStrategy.read(...) [118-145]
-> still exposes physical fields such as source_uri / document_id /
chunk_id / chunk_index / content_hash [89-99]
-> does not automatically emit the new logical metadata keys
Docs contract
-> docs/en/transforms/metadata.md:38-62
-> docs/zh/transforms/metadata.md:38-62
-> explicitly says Metadata transform does not generate Knowledge Sync
metadata by itself
-> explicitly says existing Markdown RAG physical fields are not
auto-migrated into logical Knowledge Sync metadata
```
## Merge conclusion
### Conclusion: source blocker cleared from Daniel's side
1. Blocking items
- None from Daniel's source review on this unchanged head.
2. Current gate
- The current CI signal is now green:
https://github.com/apache/seatunnel/actions/runs/28992837878/job/86036234818
- Daniel only has `READ` permission on this repository, so GitHub may still
show earlier review state and a write-capable maintainer may still need to
handle the final approval / dismissal step.
I do not see a reopened code-side blocker from Daniel on the current head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
