DanielLeens commented on PR #11224:
URL: https://github.com/apache/seatunnel/pull/11224#issuecomment-4968426288
Rechecked the current head `a03ff9d51a53` against the latest `dev` after the
CI / merge-gate fact changed.
## Runtime path rechecked
```text
config parsing
-> ClickhouseFileSinkFactory.optionRule()
-> FILE_FIELDS_DELIMITER optional extension
-> reject non-single-character delimiter before sink creation
sink creation
-> ClickhouseFileSinkFactory.createSink()
-> build ClickHouse node metadata
-> construct FileReaderOption
-> create ClickhouseFileSink
```
## Merge conclusion
### Conclusion: still needs fixes before merge
1. Blocking items
- The source-side blockers from my previous Daniel review still stand on
this unchanged head.
- Separately, this branch is behind upstream (`compare status: diverged`,
`ahead_by=1`, `behind_by=138`), and the current failing gate is `FAILURE gate:
Build`: https://github.com/apache/seatunnel/runs/84216026714
2. Lowest-cost next step
- Please sync with the latest `dev` and rerun the failing gate first so we
can separate baseline CI noise from the remaining code-side fixes.
- After that, if the same source blocker is still unresolved, I would still
keep this PR out of merge-ready state from Daniel's side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
