DanielLeens commented on PR #9993:
URL: https://github.com/apache/seatunnel/pull/9993#issuecomment-4968435945
Rechecked the current head `722fe384e10f` against the latest `dev` after the
CI / merge-gate fact changed.
## Runtime path rechecked
```text
Local or CI build starts
-> root pom.xml
-> defines seatunnel.shade.* versions
-> dependencyManagement points modules at external
org.apache.seatunnel:seatunnel-shade-* artifacts
CI path
-> backend.yml job
-> uses ./.github/actions/setup-maven
-> writes ~/.m2/settings.xml
-> adds apache-public repository
-> disables snapshots for repository and pluginRepository
-> ./mvnw ... --no-snapshot-updates
-> can only consume released shade artifacts
Local contributor path
-> ./mvnw clean install
-> does not run the GitHub composite action
-> root pom / .mvn does not define the same repository contract
-> resolution falls back to Maven Central or the contributor's
personal Maven settings
Runtime / E2E consumers
-> seatunnel-dist assembly copies external shade jars into lib/
-> starter shade plugin excludes the external Hadoop uber jar
-> MavenJarUtil resolves the Hadoop shade jar from the local Maven
repository
-> SeaTunnelContainer / ConnectorPackageServiceContainer copy that jar
into test containers
```
## Merge conclusion
### Conclusion: still needs fixes before merge
1. Blocking items
- The source-side blockers from my previous Daniel review still stand on
this unchanged head.
- Separately, this branch is behind upstream (`compare status: diverged`,
`ahead_by=5`, `behind_by=13`), and the current failing gate is `FAILURE gate:
Build`: https://github.com/apache/seatunnel/runs/86830312874
2. Lowest-cost next step
- Please sync with the latest `dev` and rerun the failing gate first so we
can separate baseline CI noise from the remaining code-side fixes.
- After that, if the same source blocker is still unresolved, I would still
keep this PR out of merge-ready state from Daniel's side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
