zhangshenghang opened a new pull request, #11467:
URL: https://github.com/apache/seatunnel/pull/11467

   ## What does this PR do?
   
   Fixes #11463 by deriving the file appender directory from `fileLogPath` 
instead of `routingLogFilePath`. This prevents a `NullPointerException` when a 
Zeta deployment configures only `fileAppender`.
   
   ## Why is this change needed?
   
   The file-appender branch used the routing appender path only to calculate 
the substring index. That path is absent in a file-appender-only configuration, 
so log REST endpoints fail while resolving the log directory.
   
   ## Tests
   
   - Added a regression test with a file-appender-only Log4j2 configuration.
   - `JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home 
./mvnw -pl seatunnel-engine/seatunnel-engine-common test`
   - `JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home 
./mvnw -q -DskipTests verify`
   
   `./mvnw test` remains blocked before this module by existing failures in 
`seatunnel-config-shade`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to