zhangshenghang opened a new pull request, #11474:
URL: https://github.com/apache/seatunnel/pull/11474

   ### Purpose of this pull request
   Fix JDBC sink batch data errors being masked by later retry/close-time flush 
errors. For Oracle, a failed batch with auto-commit enabled can partially 
commit and later surface as ORA-00001, hiding the original data error.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. Oracle JDBC sink now uses manual commit internally even when users 
configure auto_commit=true, so failed batches stay atomic and the original data 
error is preserved. The JDBC and Oracle sink docs have been updated.
   
   ### How was this patch tested?
   - JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home 
./mvnw -pl seatunnel-connectors-v2/connector-jdbc -nsu 
-Dmaven.gitcommitid.skip=true -DskipTests -DskipIT=true -Dcheckstyle.skip=true 
-Dlicense.skip=true spotless:apply
   - JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home 
./mvnw -pl seatunnel-connectors-v2/connector-jdbc -nsu 
-Dmaven.gitcommitid.skip=true -DskipIT=true -Dcheckstyle.skip=true 
-Dlicense.skip=true 
-Dtest=JdbcOutputFormatReconnectSafetyTest,BufferedBatchStatementExecutorTest,JdbcSinkWriterTest
 test
   - JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home 
./mvnw -pl seatunnel-connectors-v2/connector-jdbc -nsu 
-Dmaven.gitcommitid.skip=true -DskipTests -DskipIT=true -Dcheckstyle.skip=true 
-Dlicense.skip=true verify
   - git diff --check
   
   Oracle E2E was not run locally because this change is covered by focused 
unit tests and the existing Oracle E2E suite requires Docker/Testcontainers 
Oracle runtime.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to